Backup cleanup: core implementation #4665
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Michal-Leszczynski
force-pushed
the
ml/4648-abort-backup-core
branch
from
93bd485 to
d5d40b0
Compare
Michal-Leszczynski
requested review from
VAveryanov8 and
karol-kokoszka
as code owners
Aborting backup consists of stopping it and performing a cleanup. We already have the capability to stop running backup, but we lack the option to perform its cleanup without going through the whole purge stage. This commit adds the cleanup capability to backup svc. For now, it only removes SM snapshots from nodes' disk, but it can be easily extended with other features if needed. Refs #4648
Since it also changes svc interfaces, it also runs `make generate`. Refs #4648
Michal-Leszczynski
force-pushed
the
ml/4648-abort-backup-core
branch
from
d5d40b0 to
1a32ad5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a way of triggering backup cleanup (
sctool backup cleanup).For now, the only cleanup that it can perform is to delete SM snapshots from all SM noes in the cluster.
It is easy to add more cleanup procedures to this command if needed.
This PR also adds swagger definitions, but managerclient and sctool
commands need to be added in separate PRs (managerclient is a vendored submodule
and sctool commands depend on it).
Full implementation (made with go work) can be checked here: #4664
Refs #4648